The kernel recently added new warnings, one of which triggers a known
false positive on the etas_es58x module. In an effort to keep
es58x_etas free of any W=12 (excluding those produced by foreign
headers), add a workaround to silence it.
While at it, this series also fix a checkpatch warning which I knew
existed for a long time but was too lazy to tackle.
* Changelog *
v2 -> v3:
* if the parsing of one of the version/revision numbers fail,
es58x_parse_product_info() immediately returns. If this occurs
early, the other version/revision numbers would still be set to
zero (which is now considered a valid version number). Set the
version and revision to an invalid number before startnig the
parsing so that everything is set even if an early return occurs.
v1 -> v2:
* v1 had two different check logics for the version numbers:
- check that none of the sub-version number are zero to make sure
the parsing succeeded
- check that all of the sub-version number fit the expected digit
range to please GCC.
v2 simplifies things by merging those two logics together.
Vincent Mailhol (2):
can: etas_es58x: rework the version check logic to silence
-Wformat-truncation
can: etas_es58x: add missing a blank line after declaration
drivers/net/can/usb/etas_es58x/es58x_core.c | 1 +
drivers/net/can/usb/etas_es58x/es58x_core.h | 6 +-
.../net/can/usb/etas_es58x/es58x_devlink.c | 57 +++++++++++++------
3 files changed, 43 insertions(+), 21 deletions(-)
--
2.41.0
