Hello Martin,
I reduced the recipient list as this is a CAN-only feature discussion
which is not relevant for putting all the netdev maintainers into the
loop now.
Nice that you picked up the idea for hardware filtering.
On 2023-08-17 12:10, Martin Hundebøll wrote:
Based on the prior discussions on hardware filtering in CAN devices[0],
I've implemented such support in the m_can driver.
The first patch is almost entirely identical to Oliver Hartkopp's patch
from 2018[1] - I've just rebased it to v6.6 and fixed a checkpatch
warning. Not sure what to do about the "Not-Signed-off-by" tag though?
The patch was just for the discussion we had in 2018 and I wanted to
make sure this RFC stuff does not go upstream at that point. So
preserving myself as author would still be ok ;-)
The second patch is new. I've tested it with a tcan4550 device together
with Oliver's proof-of-concept change in iproute2[2].
Has anyone tried this approach with other devices, e.g. sja1000 ?
Yes, I remember implementing some code for the SJA1000 - but never
posted it on the CAN-ML. Maybe I still have that code somewhere o_O
But it is nice to see, that you got it working with the M_CAN IP core!
Best regards,
Oliver
Thanks,
Martin
[0] https://lore.kernel.org/linux-can/6B05F8DE-7FF3-4065-9828-530BB9C91D1B@xxxxxxxxxx/T/
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/commit/?h=can-hw-filter&id=87128f7a953ef2eef5f2d2a02ce354350e2c4f7f
[2] https://marc.info/?l=linux-can&m=151949929522529
Martin Hundebøll (2):
can: netlink: support setting hardware filters
can: m_can: support setting hw filters
drivers/net/can/dev/dev.c | 3 +
drivers/net/can/dev/netlink.c | 33 ++++++++
drivers/net/can/m_can/m_can.c | 137 ++++++++++++++++++++++++++++++-
include/linux/can/dev.h | 5 ++
include/uapi/linux/can/netlink.h | 1 +
5 files changed, 175 insertions(+), 4 deletions(-)
