On 07.08.2023 09:16:41, Marc Kleine-Budde wrote: > On 06.08.2023 13:42:28, Jernej Škrabec wrote: > > Dne nedelja, 06. avgust 2023 ob 08:33:45 CEST je John Watts napisal(a): > > > On Sat, Aug 05, 2023 at 07:49:51PM +0200, Jernej Škrabec wrote: > > > > Dne sobota, 05. avgust 2023 ob 18:51:53 CEST je John Watts napisal(a): > > > > > On Sat, Aug 05, 2023 at 07:40:52PM +0300, Maksim Kiselev wrote: > > > > > > Hi John, Jernej > > > > > > Should we also keep a pinctrl nodes itself in alphabetical order? > > > > > > I mean placing a CAN nodes before `clk_pg11_pin` node? > > > > > > Looks like the other nodes sorted in this way... > > > > > > > > > > Good catch. Now that you mention it, the device tree nodes are sorted > > > > > by memory order too! These should be after i2c3. > > > > > > > > > > It looks like I might need to do a patch to re-order those too. > > > > > > > > It would be better if DT patches are dropped from netdev tree and then > > > > post > > > > new versions. > > > > > > > > Best regards, > > > > Jernej > > > > > > Agreed. Is there a way to request that? Or will the maintainer just read > > > this? > > > > Hopefully it will. > > I'm just catching up on last week's post (I had a long off-line > weekend). > > I'll revert the DT changes and send a PR to net-next. Here's the revert: | https://lore.kernel.org/all/20230807-riscv-allwinner-d1-revert-can-controller-nodes-v1-1-eb3f70b435d9@xxxxxxxxxxxxxx/ Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature
