Re: [PATCH 2/2] can: ti_hecc: fix coding style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 20.06.23 08:31, Marc Kleine-Budde wrote:
On 19.06.2023 20:55:28, Oliver Hartkopp wrote:


On 19.06.23 15:10, Marc Kleine-Budde wrote:
This patch aligns code to match open parenthesis.

Fixes: eb38c2053b67 ("can: rx-offload: rename can_rx_offload_queue_sorted() -> can_rx_offload_queue_timestamp()")

Does it really make sense to add a "Fixes:" tag for editorial stuff?

Yes, why not. I like keeping track if things. Also the
process/maintainer-netdev.rst says:

| - for fixes the ``Fixes:`` tag is required, regardless of the tree

I do not think that whitespace changes can be categorized as "fixes" as they do not fix any functionality.

IMO this is not the intention of that sentence.

Best,
Oliver


Will this potentially trigger the stable guys?

If it does, it should be a big warning that they take too many patches.

Marc




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux