Re: [PATCH] can: kvaser_usb_leaf: Implement CAN 2.0 raw DLC functionality.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/12/23 21:01, Carsten Schmidt wrote:
Hello Jimmy,

Hi Carsten,

yes, please do make a v2 patch!

Now I've sent an updated patch:
https://lore.kernel.org/linux-can/20230516125332.82894-1-extja@xxxxxxxxxx

As this is my first patch, I am very thankful for any support to get
the work into the main kernel! Thank you!

Ahh, nice :)
And again, thanks for this patch!

Best regards,
jimmy

@Oliver: Thanx for the encouragement and guidance with the patch!

Sincerely,
Carsten



Am 11.05.2023 um 17:42 schrieb Jimmy Assarsson:
On 2023-05-08 18:40, Jimmy Assarsson wrote:
Hi Carsten,
Hi Oliver,

On 5/6/23 21:10, Oliver Hartkopp wrote:
Thanks for your patch Carsten!

There should be at least one sentence in the commit message even when
the subject almost covers the story ;-)

@Carsten, thanks for the patch!

Acked-by: Jimmy Assarsson <extja@xxxxxxxxxx>
Tested-by: Jimmy Assarsson <extja@xxxxxxxxxx>

Can you also please change the subject to

can: kvaser_usb: add len8_dlc support for kvaser_usb_leaf

to follow up with the other len8_dlc patches?

@Jimmy: AFAIK Carsten only has a Kvaser USB Leaf for testing. Can you
probably provide and test a similar improvement for the Kvaser USB
Hydra hardware?


@Oliver, yes, I'll fix this for the remaining Kvaser USB devices.
I'll try to send a patch for it by the end of the week.

Best regards,
jimmy

Hi Carsten,

I've implemented cc-len8-dlc support for the Kvaser USB Hydra devices.
Is it OK if I add my changes to your patch, and send it is as a V2?

Best regards,
jimmy

Many thanks,
Oliver



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux