On Tue, May 16, 2023 at 09:31:04AM +0200, Simon Horman wrote: > On Fri, May 12, 2023 at 11:27:06PM +0200, Uwe Kleine-König wrote: > > Hello, > > > > this series convers the drivers below drivers/net/can to the > > .remove_new() callback of struct platform_driver(). The motivation is to > > make the remove callback less prone for errors and wrong assumptions. > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > > returns no value") for a more detailed rationale. > > > > All drivers already returned zero unconditionally in their > > .remove() callback, so converting them to .remove_new() is trivial. > > Hi Uwe, > > I like these changes and they all look good to me. > However, I have a question, perhaps more directed at the netdev > maintainers than yourself. > > In principle patch-sets for netdev should not include more than 15 patches. > It's unclear to me if, on the basis of that, this patchset should > be split up. Or if, f.e. given the simple nature of the patches, > an exception applies in this case. Or something else. > > I have no fixed opinion on this. > But I feel that the question should be asked. > > Link: https://kernel.org/doc/html/v6.1/process/maintainer-netdev.html > > ... I now realise this series is for can. Which I assume means the guidance above doesn't apply. Sorry for the noise.