On 09.05.2023 10:28:13, Vincent MAILHOL wrote: > > > ip --details link show canX > > Yes, I know. But my intention was to exactly and directly see the > > individual values passed to the USB set baudrate command without using > > wireshark to sniff the USB, if anybody complains about problems with > > the bitrate. > > That's my point, this is meant for troubleshooting, not for normal > use. The calculation is not rocket science. If a user has an issue > with the bitrate, the values provided by the ip tool are enough for > you to recalculate the actual values passed to the device. You should > not spam the user just to save you the time to do this calculation. > > > This netdev_info is similar to the "netdev_info(netdev, > > "setting BTR=%#x\n", canbtr);" for CAN-USB/2. > > This one should also be removed. > > > So from my point of view this is an informational message too, and not > > a debug message. > > NACK. Please make it a debug message. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature
