Re: [PATCH V7] can: usb: f81604: add Fintek F81604 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ji-Ze,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mkl-can-next/testing]
[also build test WARNING on linus/master v6.4-rc1 next-20230509]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ji-Ze-Hong-Peter-Hong/can-usb-f81604-add-Fintek-F81604-support/20230509-154045
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
patch link:    https://lore.kernel.org/r/20230509073821.25289-1-peter_hong%40fintek.com.tw
patch subject: [PATCH V7] can: usb: f81604: add Fintek F81604 support
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230509/202305091802.pRFS6n2j-lkp@xxxxxxxxx/config)
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/9549380f8d5eea359f8c83f48e10a0becfd13541
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ji-Ze-Hong-Peter-Hong/can-usb-f81604-add-Fintek-F81604-support/20230509-154045
        git checkout 9549380f8d5eea359f8c83f48e10a0becfd13541
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202305091802.pRFS6n2j-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/net/can/usb/f81604.c: In function 'f81604_read_bulk_callback':
>> drivers/net/can/usb/f81604.c:440:67: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
     440 |                 netdev_warn(netdev, "URB length %u not equal to %lu\n",
         |                                                                 ~~^
         |                                                                   |
         |                                                                   long unsigned int
         |                                                                 %u
     441 |                             urb->actual_length, sizeof(*frame));
         |                                                 ~~~~~~~~~~~~~~     
         |                                                 |
         |                                                 unsigned int


vim +440 drivers/net/can/usb/f81604.c

   411	
   412	static void f81604_read_bulk_callback(struct urb *urb)
   413	{
   414		struct f81604_can_frame *frame = urb->transfer_buffer;
   415		struct net_device *netdev = urb->context;
   416		int ret;
   417	
   418		if (!netif_device_present(netdev))
   419			return;
   420	
   421		if (urb->status)
   422			netdev_info(netdev, "%s: URB aborted %pe\n", __func__,
   423				    ERR_PTR(urb->status));
   424	
   425		switch (urb->status) {
   426		case 0: /* success */
   427			break;
   428	
   429		case -ENOENT:
   430		case -EPIPE:
   431		case -EPROTO:
   432		case -ESHUTDOWN:
   433			return;
   434	
   435		default:
   436			goto resubmit_urb;
   437		}
   438	
   439		if (urb->actual_length != sizeof(*frame)) {
 > 440			netdev_warn(netdev, "URB length %u not equal to %lu\n",
   441				    urb->actual_length, sizeof(*frame));
   442			goto resubmit_urb;
   443		}
   444	
   445		f81604_process_rx_packet(netdev, frame);
   446	
   447	resubmit_urb:
   448		ret = usb_submit_urb(urb, GFP_ATOMIC);
   449		if (ret == -ENODEV)
   450			netif_device_detach(netdev);
   451		else if (ret)
   452			netdev_err(netdev,
   453				   "%s: failed to resubmit read bulk urb: %pe\n",
   454				   __func__, ERR_PTR(ret));
   455	}
   456	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux