Re: [PATCH] can: isotp: use sock_recv_cmsgs() to get SOCK_RXQ_OVFL infos

[Oliver Hartkopp <socketcan@xxxxxxxxxxxx>]

Hi Marc,

can you please apply this one too?
I was using it to detect the poll receive buffer error.

Thanks,
Oliver

On 30.03.23 19:02, Oliver Hartkopp wrote:
> isotp.c was still using sock_recv_timestamp() which does not provide
> control messages to detect dropped PDUs in the receive path.
>
> Fixes: e057dd3fc20f ("can: add ISO 15765-2:2016 transport protocol")
> Signed-off-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
> ---
>   net/can/isotp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/can/isotp.c b/net/can/isotp.c
> index 9bc344851704..47c2ebad10ed 100644
> --- a/net/can/isotp.c
> +++ b/net/can/isotp.c
> @@ -1118,11 +1118,11 @@ static int isotp_recvmsg(struct socket *sock, struct msghdr *msg, size_t size,
>   
>   	ret = memcpy_to_msg(msg, skb->data, size);
>   	if (ret < 0)
>   		goto out_err;
>   
> -	sock_recv_timestamp(msg, sk, skb);
> +	sock_recv_cmsgs(msg, sk, skb);
>   
>   	if (msg->msg_name) {
>   		__sockaddr_check_size(ISOTP_MIN_NAMELEN);
>   		msg->msg_namelen = ISOTP_MIN_NAMELEN;
>   		memcpy(msg->msg_name, skb->cb, msg->msg_namelen);