[PATCH] can: CAN_BXCAN should depend on ARCH_STM32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The STMicroelectronics STM32 basic extended CAN Controller (bxCAN) is
only present on STM32 SoCs.  Hence drop the "|| OF" part from its
dependency rule, to prevent asking the user about this driver when
configuring a kernel without STM32 SoC support.

Fixes: f00647d8127be4d3 ("can: bxcan: add support for ST bxCAN controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
---
Until v3[1], BXCAN depended on "(ARCH_STM32 || COMPILE_TEST) && OF".
v4[2] changed this from "&& OF" to "|| OF", for no apparent reason, and
without mentioning this in the changelog.

[1] https://lore.kernel.org/all/20220828133329.793324-5-dario.binacchi@xxxxxxxxxxxxxxxxxxxx
[2] https://lore.kernel.org/all/20220925175209.1528960-6-dario.binacchi@xxxxxxxxxxxxxxxxxxxx
---
 drivers/net/can/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
index 3ceccafd701b2a31..b190007c01bec5f4 100644
--- a/drivers/net/can/Kconfig
+++ b/drivers/net/can/Kconfig
@@ -95,7 +95,7 @@ config CAN_AT91
 
 config CAN_BXCAN
 	tristate "STM32 Basic Extended CAN (bxCAN) devices"
-	depends on OF || ARCH_STM32 || COMPILE_TEST
+	depends on ARCH_STM32 || COMPILE_TEST
 	depends on HAS_IOMEM
 	select CAN_RX_OFFLOAD
 	help
-- 
2.34.1




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux