On 26.03.2023 18:07:14, Dario Binacchi wrote: > > On 21.03.2023 12:25:15, Dario Binacchi wrote: > > > A gentle ping to remind you of this series. > > > I have no idea why it hasn't deserved any response for quite some > > > time. > > > Is there anything I am still missing? > > > > I wonder if we want to do a s/master/primary/ in the DT bindings and > > driver? > > The ST reference manual (RM0386) explicitly uses the master and slave words > in the bxcan chapter. ACK > I would stay consistent with it. Yes, this is a known problem, on the one hand I'd like the drivers to match the datasheet, but here I am in favor of a deviation. > But I have no problem changing it to primary. I just sent v8 with the > changes you suggested for shared irq and clock enable/disable, These changes look good! > but if you prefer to use primary I will send the v9 version with that > change. Please let me know your opinion. Please convert the driver and bindings to use "primary". Feel free to mention that the datasheet calls the primary peripheral "master". Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
