Re: error: too many arguments to function ‘can_calc_bittiming’

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09.02.2023 18:05:06, Randy Dunlap wrote:
> > It's possible to have a kernel .config (randconfig) file with
> > # CONFIG_CAN_CALC_BITTIMING is not set
> > 
> > which ends up with different number of arguments to can_calc_bittiming().
> > 
> > Full compiler error listing is:
> > 
> > ../drivers/net/can/dev/bittiming.c: In function ‘can_get_bittiming’:
> > ../drivers/net/can/dev/bittiming.c:145:24: error: too many arguments to function ‘can_calc_bittiming’
> >   145 |                 return can_calc_bittiming(dev, bt, btc, extack);
> >       |                        ^~~~~~~~~~~~~~~~~~
> > In file included from ../include/linux/can/dev.h:18,
> >                  from ../drivers/net/can/dev/bittiming.c:7:
> > ../include/linux/can/bittiming.h:126:1: note: declared here
> >   126 | can_calc_bittiming(const struct net_device *dev, struct can_bittiming *bt,
> >       | ^~~~~~~~~~~~~~~~~~
> > 
> > 
> > A failing i386 .config file is attached.
> > 
> > Do you have any suggestions for resolving this error?

The problem is already fixed in current net-next/main:

| 65db3d8b5231 ("can: bittiming: can_calc_bittiming(): add missing parameter to no-op function")

sorry for the mess,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux