Hi Gerhard, I had a quick look at your series. I have a couple of nitpicks. The rest looks good. On Fri. 20 Jan. 2023 at 01:02, Gerhard Uttenthaler <uttenthaler@xxxxxxxxxxxxxxxx> wrote: > The CPC-PCIe v3 uses a Asix AX99100 instead of the discontinued > PLX PCI9030 bridge chip. This patch series adds support for this > card version and cleaned some code styling issues. > > Gerhard Uttenthaler (8): > Fixed code style, copyright and email address > Added Asix AX99100 definitions > Initialize BAR registers > Added read/write register and post irq functions > Initialize CAN controller base addresses > Added IRQ enable > Deassert hardware reset > Added MODULE_AUTHOR > Fixed code style, copyright and email address ^^^^^ > Added Asix AX99100 definitions ^^^^^ > Initialize BAR registers > Added read/write register and post irq functions ^^^^^ > Initialize CAN controller base addresses > Added IRQ enable ^^^^^ > Deassert hardware reset > Added MODULE_AUTHOR ^^^^^ For the titles, please use imperative (e.g. add) instead of past tense (e.g. Added). This also applies to the description. > > drivers/net/can/sja1000/ems_pci.c | 152 ++++++++++++++++++++++-------- > 1 file changed, 113 insertions(+), 39 deletions(-) > > -- > 2.35.3 > > -- > EMS Dr. Thomas Wuensche e.K. > Sonnenhang 3 > 85304 Ilmmuenster > HR Ingolstadt, HRA 170106 > > Phone: +49-8441-490260 > Fax : +49-8441-81860 > http://www.ems-wuensche.com