Re: RE: [PATCH net-next 11/39] can: flexcan: add auto stop mode for IMX93 to support wakeup

[Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>]

On 13.12.2022 02:22:02, Bough Chen wrote:
> > -----Original Message-----
> > From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> > Sent: 2022年12月12日 19:30
> > To: netdev@xxxxxxxxxxxxxxx
> > Cc: davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; linux-can@xxxxxxxxxxxxxxx;
> > kernel@xxxxxxxxxxxxxx; Bough Chen <haibo.chen@xxxxxxx>; Marc
> > Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> > Subject: [PATCH net-next 11/39] can: flexcan: add auto stop mode for IMX93 to
> > support wakeup
> > 
> > From: Haibo Chen <haibo.chen@xxxxxxx>
> > 
> > IMX93 do not contain a GPR to config the stop mode, it will set the flexcan into
> > stop mode automatically once the ARM core go into low power mode (WFI
> > instruct) and gate off the flexcan related clock automatically. But to let these
> > logic work as expect, before ARM core go into low power mode, need to make
> > sure the flexcan related clock keep on.
> > 
> > To support stop mode and wakeup feature on imx93, this patch add a new
> > fsl_imx93_devtype_data to separate from imx8mp.
> > 
> > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx>
> > Link:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kern
> > el.org%2Fall%2F1669116752-4260-1-git-send-email-haibo.chen%40nxp.com&a
> > mp;data=05%7C01%7Chaibo.chen%40nxp.com%7C57db640faf1a4fe6ac9e08da
> > dc34556c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638064414
> > 581423735%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
> > 2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=
> > yc1AspfoVq%2BHKokRFxf06vcaqqP%2FtZUnpMnTaXL97y8%3D&amp;reserved=
> > 0
> > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> 
> Hi Marc,
> 
> Thanks for sending this patch.
> But this patch has one runtime PM unbalance issue, I will fix this issue and send again these days.

It's in net-next now, please send an incremental patch.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature