On 03.12.2022 01:01:48, Max Staudt wrote: > Additionally, remove it from .ndo_stop(). > > This ensures that the worker is not called after being freed, and that > the UART TX queue remains active to send final commands when the netdev > is stopped. > > Thanks to Jiri Slaby for finding this in slcan: > > https://lore.kernel.org/linux-can/20221201073426.17328-1-jirislaby@xxxxxxxxxx/ > > A variant of this patch for slcan, with the flush in .ndo_stop() still > present, has been tested successfully on physical hardware: > > https://bugzilla.suse.com/show_bug.cgi?id=1205597 > > Fixes: 43da2f07622f ("can: can327: CAN/ldisc driver for ELM327 based OBD-II adapters") > Cc: "Jiri Slaby (SUSE)" <jirislaby@xxxxxxxxxx> > Cc: Max Staudt <max@xxxxxxxxx> > Cc: Wolfgang Grandegger <wg@xxxxxxxxxxxxxx> > Cc: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: Eric Dumazet <edumazet@xxxxxxxxxx> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx> > Cc: Paolo Abeni <pabeni@xxxxxxxxxx> > Cc: linux-can@xxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Max Staudt <max@xxxxxxxxx> Applied to linux-can. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
