On 29.11.2022 17:15:56, Frank Jungclaus wrote: > Hello Marc, > thanks for commenting. > > On Fri, 2022-11-25 at 16:56 +0100, Marc Kleine-Budde wrote: > > On 24.11.2022 21:38:06, Frank Jungclaus wrote: > > > We don't get any further EVENT from an esd CAN USB device for changes > > > on REC or TEC while those counters converge to 0 (with ecc == 0). > > > So when handling the "Back to Error Active"-event force > > > txerr = rxerr = 0, otherwise the berr-counters might stay on > > > values like 95 forever ... > > > > > > Also, to make life easier during the ongoing development a > > > netdev_dbg() has been introduced to allow dumping error events send by > > > an esd CAN USB device. > > > > > > Signed-off-by: Frank Jungclaus <frank.jungclaus@xxxxxx> > > > > Please add a Fixes tag. > > > > https://elixir.bootlin.com/linux/v6.0/source/Documentation/process/handling-regressions.rst#L107 > > > From my point of view this is not a regression, it's a sort of > imperfection existing since the initial add of esd_usb(2).c to the > kernel. So should I add a "Fixes:" referring to the initial commit? > (Currently) I'm slow on the uptake ;) Please add a fixes tag that refers to the code that this patch fixes. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
