Re: [PATCH v4 5/6] can: etas_es58x: report the firmware version through ethtool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
Subject: Re: [PATCH v4 5/6] can: etas_es58x: report the firmware version through ethtool
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Mon, 28 Nov 2022 14:29:05 -0800
Cc: linux-can@xxxxxxxxxxxxxxx, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, Saeed Mahameed <saeed@xxxxxxxxxx>, Andrew Lunn <andrew@xxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxx>, Lukas Magel <lukas.magel@xxxxxxxxxx>
In-reply-to: <20221126162211.93322-6-mailhol.vincent@wanadoo.fr>
References: <20221104073659.414147-1-mailhol.vincent@wanadoo.fr> <20221126162211.93322-1-mailhol.vincent@wanadoo.fr> <20221126162211.93322-6-mailhol.vincent@wanadoo.fr>

On Sun, 27 Nov 2022 01:22:10 +0900 Vincent Mailhol wrote:
> Implement ethtool_ops::get_drvinfo() in order to report the firmware
> version.
> 
> Firmware version 0.0.0 has a special meaning and just means that we
> could not parse the product information string. In such case, do
> nothing (i.e. leave the .fw_version string empty).

devlink_compat_running_version() does not work?

Follow-Ups:
- Re: [PATCH v4 5/6] can: etas_es58x: report the firmware version through ethtool
  - From: Vincent MAILHOL

References:
- [PATCH] can: etas_es58x: report the firmware version through ethtool
  - From: Vincent Mailhol
- [PATCH v4 0/6] can: etas_es58x: report firmware, bootloader and hardware version
  - From: Vincent Mailhol
- [PATCH v4 5/6] can: etas_es58x: report the firmware version through ethtool
  - From: Vincent Mailhol

Prev by Date: Re: [PATCH v4 3/6] can: etas_es58x: export product information through devlink_ops::info_get()
Next by Date: Re: [RFC][PATCH 0/2] LIN support for Linux
Previous by thread: Re: [PATCH v4 5/6] can: etas_es58x: report the firmware version through ethtool
Next by thread: Re: [PATCH v4 5/6] can: etas_es58x: report the firmware version through ethtool
Index(es):
- Date
- Thread

[Index of Archives] [Automotive Discussions] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [CAN Bus]