On Mon. 28 Nov. 2022 at 00:08, Andrew Lunn <andrew@xxxxxxx> wrote: > > I checked, none of gcc and clang would trigger a warning even for a > > 'make W=12'. More generally speaking, I made sure that my driver is > > free of any W=12. > > That is good enough for me. > > > I do not care any more as long as it does not result in > > undefined behaviour. > > Agreed. Hopefully sscanf cannot go completely wrong and go off the end > of the buffer. That i would care about. Bit i guess the USB fuzzers > would of hit such problems already. On the surface, the sscanf() seems OK. It will break the while loop when reaching the end of the format: https://elixir.bootlin.com/linux/v6.1-rc6/source/lib/vsprintf.c#L3429 or the end of the string: https://elixir.bootlin.com/linux/v6.1-rc6/source/lib/vsprintf.c#L3501 (I am skipping details here, there are other branches that will break the while loop and all of them look good). And me not being the first person using sscanf(), I hope that if a bug existed, it would have already been spotted by some static analysis/fuzzing/code review :) That said, I think I answered all your comments. Can I get your reviewed-by or ack tag? Thank you! Yours sincerely, Vincent Mailhol
