On 26.11.2022 08:04:11, Greg Kroah-Hartman wrote:
> On Fri, Nov 25, 2022 at 09:32:17PM +0100, Marc Kleine-Budde wrote:
> > Hello Greg,
> >
> > with v5.18-rc1 in commit
> >
> > | c359931d2545 ("can: gs_usb: use union and FLEX_ARRAY for data in struct gs_host_frame")
> >
> > a bug in the gs_usb driver in the usage of usb_free_coherent() was
> > introduced. With v6.1-rc1
> >
> > | 62f102c0d156 ("can: gs_usb: remove dma allocations")
> >
> > the DMA allocation was removed altogether from the driver, fixing the
> > bug unintentionally.
> >
> > We can either cherry-pick 62f102c0d156 ("can: gs_usb: remove dma
> > allocations") on v6.0, v5.19, and v5.18 or apply this patch, which fixes
> > the usage of usb_free_coherent() only.
>
> We should always take what is in Linus's tree, that's the best
> solution.
Ok.
> Does the change backport cleanly?
ACK.
> And 5.19 and 5.18 are long end-of-life, no need to worry about them.
> Only 6.0 matters right now.
Please queue 62f102c0d156 ("can: gs_usb: remove dma allocations") for
v6.0.x and add the fixes tag:
Fixes: c359931d2545 ("can: gs_usb: use union and FLEX_ARRAY for data in struct gs_host_frame")
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
