Re: [PATCH can-utils-dev v3 0/6] can-utils-dev: a set of update and cleanup patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 14.11.22 17:38, Vincent Mailhol wrote:
This series contain cleanup patches and update of header files. There
is no real relation between each patch (aside of 2/6 and 3/6 which
form a pair) so I will end the cover letter here and let you refer to
the short description.

Nice cleanups.

Thanks Vincent!

Acked-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>


* Changelog *

v2 -> v3:

   * reorder the patches so that related changes are next to each
     other (especially patch 2/6 and 3/6).

   * patch 2/6: new patch to update include/linux/can/error.h with the
     latest hearder from Linux 6.0.0.

   * patch 3/6: do not use an #ifdef anymore and make sure that the
     code still work if run on old kernel version lower than 6.0.0.

   * patch 6/6: rewrite commit description to point out that there is a
     local copy of the linux headers under include/linux/.

v1 -> v2:

   * patch 2/5: add a note in commit message to explain that slcanpty.c
     debug is deactivated by default.

   * patch 2/5: make the compiler check the pr_debug() syntax even if
     debug is off.

   * reorder the patches so that the lib.c and the candump.c patches
     are next to each other in the series.

Vincent Mailhol (6):
   slcanpty: remove redundant asc2nibble()
   include: update linux/can/error.h
   lib: snprintf_can_error_frame: print counter errors if CAN_ERR_CNT is
     set
   lib: add pr_debug() macro
   candump: add global variable progname
   candump: use linux/net_tstamp.h instead of redefining values ourselves

  Makefile                           |  2 ++
  canbusload.c                       |  9 ++---
  candump.c                          | 58 +++++++++++++-----------------
  canlogserver.c                     | 12 +++----
  include/linux/can/error.h          | 20 ++++++++++-
  lib.c                              |  2 +-
  lib.h                              |  7 ++++
  mcp251xfd/mcp251xfd-dev-coredump.c | 10 +-----
  slcanpty.c                         | 27 +++-----------
  9 files changed, 67 insertions(+), 80 deletions(-)




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux