On 14.11.22 06:25, Vincent MAILHOL wrote:
On Mon. 14 Nov. 2022 at 05:05, Oliver Hartkopp <socketcan@xxxxxxxxxxxx> wrote:
On 13.11.22 09:53, Vincent Mailhol wrote:
No need to redefine values when available in header.
linux/net_tstamp.h is available since Linux 2.6.30 while socket CAN
was introduced in v2.6.25. These being old releases not being
maintained any more for many years, dropping support is
acceptable.
Regardless, candump already relies on some other macros defined in
more recent kernel version (e.g. CAN_RAW_ERR_FILTER) meaning that it
would not build on old linux kernel environments.
The patch is right but this text does not fit IMO.
We have a copy of net_tstamp.h in this repository to make sure we can
always build the latest binaries with the latest kernel APIs even on
older development environments/kernels.
You are right. I missed the fact that there was a local copy of the
kernel headers at the include/linux/ directory at the root of the
project.
I will amend the description. I will also give a second thought on
patch 5/5: "lib: snprintf_can_error_frame: print counter errors if
CAN_ERR_CNT is set" as this one might have repercussions if built on a
new machine and run on an older one.
Good idea!
Thanks!
Oliver
