Re: [PATCH can-utils-dev 2/5] lib: add pr_debug() macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun. 13 Nov. 2022 at 22:12, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> On 13.11.2022 17:53:18, Vincent Mailhol wrote:
>
> > diff --git a/mcp251xfd/mcp251xfd-dev-coredump.c b/mcp251xfd/mcp251xfd-dev-coredump.c
> > index 5874d24..422900f 100644
> > --- a/mcp251xfd/mcp251xfd-dev-coredump.c
> > +++ b/mcp251xfd/mcp251xfd-dev-coredump.c
> > @@ -17,18 +17,10 @@
> >
> >  #include <linux/kernel.h>
> >
> > +#include "../lib.h"
>
> Does #include <lib.h> work?

Unfortunately, no:

  cc -O2 -Wall -Wno-parentheses -Iinclude -DAF_CAN=PF_CAN -DPF_CAN=29
-DSO_RXQ_OVFL=40 -DSCM_TIMESTAMPING_OPT_STATS=54
-D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE  -c -o
mcp251xfd/mcp251xfd-dev-coredump.o mcp251xfd/mcp251xfd-dev-coredump.c
  mcp251xfd/mcp251xfd-dev-coredump.c:20:10: fatal error: lib.h: No
such file or directory
     20 | #include <lib.h>
        |          ^~~~~~~
  compilation terminated.
  make: *** [<builtin>: mcp251xfd/mcp251xfd-dev-coredump.o] Error 1

> >  #include "mcp251xfd.h"
> >  #include "mcp251xfd-dump-userspace.h"
> >
> > -#define pr_err(fmt, args...)    fprintf(stderr, fmt, ##args)
> > -#define pr_no(fmt, args...)     while (0) { fprintf(stdout, fmt, ##args); }
> > -
> > -#ifdef DEBUG
> > -#define pr_debug(fmt, args...) pr_err(fmt, ##args)
> > -#else
> > -#define pr_debug(fmt, args...) pr_no(fmt, ##args)
> > -#endif
> > -
> >
> >  struct mcp251xfd_dump_iter {
> >       const void *start;
>
> Marc
>
> --
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux