On Sun. 6 Nov. 2022 at 21:56, Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> wrote: > Follow the best practices, reorder the includes. > > While doing so, bump up copyright year of each modified files. > > Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> > --- > > Changelog: > > v1 -> v2: > > * rebase on linux-can-next/testing. v1 was based on a local branch > and did not apply (sorry for the noise). > > * add the copyright bump. That was initially of this patch: > https://lore.kernel.org/linux-can/20221104073659.414147-1-mailhol.vincent@xxxxxxxxxx/raw > but figured out that it is better to put this next to the > modifications of the includes. > --- > drivers/net/can/usb/etas_es58x/es581_4.c | 4 ++-- > drivers/net/can/usb/etas_es58x/es58x_core.c | 6 +++--- > drivers/net/can/usb/etas_es58x/es58x_fd.c | 4 ++-- The header file es58x_core.h also has some includes which are not sorted correctly... This was meant to be a trivial patch, but finally, it will need a third revision. Please don’t take it, I will resend. And sorry for the noise. > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/can/usb/etas_es58x/es581_4.c b/drivers/net/can/usb/etas_es58x/es581_4.c > index 1bcdcece5ec7..4151b18fd045 100644 > --- a/drivers/net/can/usb/etas_es58x/es581_4.c > +++ b/drivers/net/can/usb/etas_es58x/es581_4.c > @@ -6,12 +6,12 @@ > * > * Copyright (c) 2019 Robert Bosch Engineering and Business Solutions. All rights reserved. > * Copyright (c) 2020 ETAS K.K.. All rights reserved. > - * Copyright (c) 2020, 2021 Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> > + * Copyright (c) 2020-2022 Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> > */ > > +#include <asm/unaligned.h> > #include <linux/kernel.h> > #include <linux/units.h> > -#include <asm/unaligned.h> > > #include "es58x_core.h" > #include "es581_4.h" > diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c > index 51294b717040..7d6e688f2b46 100644 > --- a/drivers/net/can/usb/etas_es58x/es58x_core.c > +++ b/drivers/net/can/usb/etas_es58x/es58x_core.c > @@ -7,15 +7,15 @@ > * > * Copyright (c) 2019 Robert Bosch Engineering and Business Solutions. All rights reserved. > * Copyright (c) 2020 ETAS K.K.. All rights reserved. > - * Copyright (c) 2020, 2021 Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> > + * Copyright (c) 2020-2022 Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> > */ > > +#include <asm/unaligned.h> > +#include <linux/crc16.h> > #include <linux/ethtool.h> > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/usb.h> > -#include <linux/crc16.h> > -#include <asm/unaligned.h> > > #include "es58x_core.h" > > diff --git a/drivers/net/can/usb/etas_es58x/es58x_fd.c b/drivers/net/can/usb/etas_es58x/es58x_fd.c > index c97ffa71fd75..fa87b0b78e3e 100644 > --- a/drivers/net/can/usb/etas_es58x/es58x_fd.c > +++ b/drivers/net/can/usb/etas_es58x/es58x_fd.c > @@ -8,12 +8,12 @@ > * > * Copyright (c) 2019 Robert Bosch Engineering and Business Solutions. All rights reserved. > * Copyright (c) 2020 ETAS K.K.. All rights reserved. > - * Copyright (c) 2020, 2021 Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> > + * Copyright (c) 2020-2022 Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> > */ > > +#include <asm/unaligned.h> > #include <linux/kernel.h> > #include <linux/units.h> > -#include <asm/unaligned.h> > > #include "es58x_core.h" > #include "es58x_fd.h" > -- > 2.37.4 >
