On 02.11.22 11:17, Vincent MAILHOL wrote:
On Wed. 2 Nov. 2022 at19:06, Oliver Hartkopp <socketcan@xxxxxxxxxxxx> wrote:
In commit a6d190f8c767 ("can: skb: drop tx skb if in listen only mode") the
priv->ctrlmode element is read even on virtual CAN interfaces that do not
create the struct can_priv at startup. This out-of-bounds read may lead to
CAN frame drops for virtual CAN interfaces like vcan and vxcan.
This patch mainly reverts the original commit and adds a new helper for CAN
interface drivers that provide the required information in struct can_priv.
Fixes: a6d190f8c767 ("can: skb: drop tx skb if in listen only mode")
Reported-by: Dariusz Stojaczyk <Dariusz.Stojaczyk@xxxxxxxxxxxxxxx>
Cc: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
Cc: Max Staudt <max@xxxxxxxxx>
Signed-off-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
Cross fire... I missed your patch and sent another one. That said:
Acked-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
Thank you!
:-D
Yes! I would be fine with both of them. The main difference is the
naming and the inline implementation.
So let us Marc decide ;-)
Acked-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
Btw. my patch is missing the pch_can driver change which was already
removed in net-next.
Best regards,
Oliver
