Re: [PATCH 5/7] can: peak_usb: add ethtool interface to user defined flashed device number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22.10.2022 21:35:33, Lukas Magel wrote:
> From: Stephane Grosjean <s.grosjean@xxxxxxxxxxxxxxx>
> 
> This patch introduces 3 new functions implementing support for eeprom
> access of USB - CAN network interfaces managed by the driver, through the
> ethtool interface. All of them (except the PCAN-USB interface) interpret
> the 4 data bytes as a 32-bit value to be read/write in the non-volatile
> memory of the device. The PCAN-USB only manages a single byte value.
> 
> Signed-off-by: Stephane Grosjean <s.grosjean@xxxxxxxxxxxxxxx>
> Signed-off-by: Lukas Magel <lukas.magel@xxxxxxxxxx>

If you compile with "C=1" sparse complains about:

| drivers/net/can/usb/peak_usb/pcan_usb_core.c:861:18: warning: incorrect type in assignment (different base types)
| drivers/net/can/usb/peak_usb/pcan_usb_core.c:861:18:    expected unsigned int [usertype] devid_le
| drivers/net/can/usb/peak_usb/pcan_usb_core.c:861:18:    got restricted __le32 [usertype]
| drivers/net/can/usb/peak_usb/pcan_usb_core.c:894:18: warning: incorrect type in assignment (different base types)
| drivers/net/can/usb/peak_usb/pcan_usb_core.c:894:18:    expected unsigned int [usertype] devid_le
| drivers/net/can/usb/peak_usb/pcan_usb_core.c:894:18:    got restricted __le32 [usertype]
| drivers/net/can/usb/peak_usb/pcan_usb_core.c:896:17: warning: cast to restricted __le32

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux