Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dongliang Mu <dzm91@xxxxxxxxxxx>
Subject: Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Mon, 24 Oct 2022 15:00:28 +0300
Cc: Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>, Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Cai Huoqing <cai.huoqing@xxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Gerhard Sittig <gsi@xxxxxxx>, Anatolij Gustschin <agust@xxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, linux-can@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20221024114810.732168-1-dzm91@hust.edu.cn>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20221024114810.732168-1-dzm91@hust.edu.cn>

On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote:
> The commit 1149108e2fbf ("can: mscan: improve clock API use
> ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add

Strange indentation. Why the '")' part can't be on the previous line?

> put_clock in the error handling code.
> 
> Fix this bug by adding put_clock in the error handling code.

-- 
With Best Regards,
Andy Shevchenko

Follow-Ups:
- Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe
  - From: Dongliang Mu

Prev by Date: [PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev
Next by Date: [PATCH v2] can: mscan: mpc5xxx: mpc5xxx_can_probe(): add missing put_clock() in error path
Previous by thread: [PATCH] can: usb: ucan: modify unregister_netdev to unregister_candev
Next by thread: Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can_probe
Index(es):
- Date
- Thread

[Index of Archives] [Automotive Discussions] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [CAN Bus]

Powered by Linux