Re: [PATCH] can: mcp251x: fix error handling code in mcp251x_can_probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dongliang Mu <dzm91@xxxxxxxxxxx>
Subject: Re: [PATCH] can: mcp251x: fix error handling code in mcp251x_can_probe
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Mon, 24 Oct 2022 11:10:27 +0300
Cc: Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>, Oliver Hartkopp <socketcan@xxxxxxxxxxxx>, Stefan Mätje <stefan.maetje@xxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, Sebastian Würl <sebastian.wuerl@xxxxxxxxxxxxx>, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>, linux-can@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20221024053711.696124-1-dzm91@hust.edu.cn>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20221024053711.696124-1-dzm91@hust.edu.cn>

On Mon, Oct 24, 2022 at 01:37:07PM +0800, Dongliang Mu wrote:
> In mcp251x_can_probe, if mcp251x_gpio_setup fails, it forgets to
> unregister the can device.
> 
> Fix this by unregistering can device in mcp251x_can_probe.

Fixes tag?

-- 
With Best Regards,
Andy Shevchenko

Follow-Ups:
- Re: [PATCH] can: mcp251x: fix error handling code in mcp251x_can_probe
  - From: Dongliang Mu

References:
- [PATCH] can: mcp251x: fix error handling code in mcp251x_can_probe
  - From: Dongliang Mu

Prev by Date: [PATCH] can: mcp251x: fix error handling code in mcp251x_can_probe
Next by Date: Re: [PATCH] can: mcp251x: fix error handling code in mcp251x_can_probe
Previous by thread: [PATCH] can: mcp251x: fix error handling code in mcp251x_can_probe
Next by thread: Re: [PATCH] can: mcp251x: fix error handling code in mcp251x_can_probe
Index(es):
- Date
- Thread

[Index of Archives] [Automotive Discussions] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [CAN Bus]