On 06.10.2022 18:24:50, Marc Kleine-Budde wrote: > From: Jeroen Hofstee <jhofstee@xxxxxxxxxxxxxxxxx> > > The open source firmware candleLight report bus errors > unconditionally. This adds support to enable / disable bus error > reporting with the standard netlink property. I haven't checked the candleLight firmware, yet. If the unmodified firmware sends bus errors per default and we introduce BERR_REPORTING as suggested in this patch, we have to modify the default behavior for bus errors: By default the firmware will not send bus errors, but only if GS_CAN_MODE_BERR_REPORTING is requested during open(). I'm not sure if we want to change the default behavior of the firmware....To work around this backwards compatibility issue we can explicitly turn BERR reporting on or off during open via GS_CAN_MODE_BERR_REPORTING_ON or GS_CAN_MODE_BERR_REPORTING_OFF. What do you think? regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
