Re: [RFC can-next] can: remove obsolete PCH CAN driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marc,

now that net-next is closed for the merge window would you consider this removal for the next can-next phase or is this something that can be still applied after the merge window to 6.1-rc1?

Best regards,
Oliver

On 26.09.22 10:55, Jacob Kroon wrote:
On 9/26/22 10:25, Marc Kleine-Budde wrote:
On 24.09.2022 22:24:07, Jacob Kroon wrote:
On 9/24/22 19:44, Oliver Hartkopp wrote:
The PCH CAN driver is a driver for a Bosch C_CAN controller IP core which is attached to the system via PCI. This code has been introduced in 2011
by Oki Semiconductors developers to support the Intel Atom E6xx series
I/O Hub (aka EG20T IOH PCH CAN). Since 2012 the driver only has been
maintained by the kernel community.

As there is a well maintained and continously tested C_CAN/D_CAN driver
which also supports the PCI configuration from the PCH CAN EG20T setup
this driver became obsolete.

Cc: Jacob Kroon <jacob.kroon@xxxxxxxxx>
Cc: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Cc: Dario Binacchi <dariobin@xxxxxxxxx>
Cc: Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>
Signed-off-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
---
   drivers/net/can/Kconfig       |    8 -
   drivers/net/can/Makefile      |    1 -
   drivers/net/can/c_can/Kconfig |    3 +-
   drivers/net/can/pch_can.c     | 1249 ---------------------------------
   4 files changed, 2 insertions(+), 1259 deletions(-)
   delete mode 100644 drivers/net/can/pch_can.c


Given that the current PCH driver will lockup on my system I'm all for
removing it.

Should I add your Acked-by?


Although I doubt my name carries any weight in this context, yes feel free to do so.

Jacob



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux