On Tue, Sep 27, 2022 at 11:21 AM Eric Dumazet <edumazet@xxxxxxxxxx> wrote: > > On Tue, Sep 27, 2022 at 6:28 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > > > We tell driver developers to always pass NAPI_POLL_WEIGHT > > as the weight to netif_napi_add(). This may be confusing > > to newcomers, drop the weight argument, those who really > > need to tweak the weight can use netif_napi_add_weight(). > > > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > > Sure, but this kind of patch makes backports harder. > Not sure how confused are newcomers about this NAPI_POLL_WEIGHT.... Ironically we've been fiddling with dramatically reducing the NAPI_POLL_WEIGHT (8) on several multicore arm systems, with good results, especially on ath10k. -- FQ World Domination pending: https://blog.cerowrt.org/post/state_of_fq_codel/ Dave Täht CEO, TekLibre, LLC
