Hi,
On 1.9.2022 15.27, Jimmy Assarsson wrote:
> Use the CMD_GET_CAPABILITIES_REQ command to query the device for certain
> capabilities. We are only interested in LISTENONLY mode and wither the
> device reports CAN error counters.
>
> And remove hard coded capabilities for all Leaf devices.
I think the second paragraph is no longer accurate.
But the patch itself works for me now with no regressions that I can see.
Tested-by: Anssi Hannula <anssi.hannula@xxxxxxxxxx>
Thanks for taking care of the patchset!
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 080f40a6fa28 ("can: kvaser_usb: Add support for Kvaser CAN/USB devices")
> Reported-by: Anssi Hannula <anssi.hannula@xxxxxxxxxx>
> Signed-off-by: Jimmy Assarsson <extja@xxxxxxxxxx>
> ---
> Changes in v3
> - Rebased on 1d5eeda23f36 ("can: kvaser_usb: advertise timestamping capabilities and add ioctl support")
> - Add stable to CC
> - Re-add hard coded capabilities for Leaf M32C devices, to fix regression
> found by Anssi Hannula in v2 [1].
>
> Changes in v2:
> - New in v2. Replaces [PATCH 04/12] can: kvaser_usb: Mark Mini PCIe 2xHS as supporting
> error counters
> - Fixed Anssi's comments; https://lore.kernel.org/linux-can/9742e7ab-3650-74d8-5a44-136555788c08@xxxxxxxxxx/
>
> [1] https://lore.kernel.org/linux-can/b25bc059-d776-146d-0b3c-41aecf4bd9f8@xxxxxxxxxx/
>
> .../net/can/usb/kvaser_usb/kvaser_usb_leaf.c | 144 +++++++++++++++++-
> 1 file changed, 143 insertions(+), 1 deletion(-)
>
[...]
--
Anssi Hannula / Bitwise Oy
+358 503803997
