Re: [PATCH] can: etas_es58x: remove useless calls to usb_fill_bulk_urb()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29.07.2022 17:09:02, Vincent Mailhol wrote:
> Aside of urb->transfer_buffer_length and urb->context which might
> change in the TX path, all the other URB parameters remains constant
> during runtime. So, there is no reasons to call usb_fill_bulk_urb()
> each time before submitting an URB.
> 
> Make sure to initialize all the fields of the URB at allocation
> time. For the TX branch, replace the call usb_fill_bulk_urb() by an
> assignment of urb->context. urb->urb->transfer_buffer_length is
> already set by the caller functions, no need to set it again. For the
> RX branch, because all parameters are unchanged, simply remove the
> call to usb_fill_bulk_urb().
> 
> Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>

Applied to linux-can-next/master

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux