Re: [RFC PATCH v3 3/9] can: slcan: remove legacy infrastructure

To: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [RFC PATCH v3 3/9] can: slcan: remove legacy infrastructure
From: Max Staudt <max@xxxxxxxxx>
Date: Wed, 27 Jul 2022 19:09:28 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, Oliver Hartkopp <socketcan@xxxxxxxxxxxx>, michael@xxxxxxxxxxxxxxxxxxxx, Amarula patchwork <linux-amarula@xxxxxxxxxxxxxxxxxxxx>, Jeroen Hofstee <jhofstee@xxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx
In-reply-to: <20220726210217.3368497-4-dario.binacchi@amarulasolutions.com>
References: <20220726210217.3368497-1-dario.binacchi@amarulasolutions.com> <20220726210217.3368497-4-dario.binacchi@amarulasolutions.com>

Hi Dario,

This looks good to me now.

Thank you for cleaning up the legacy code :)


Reviewed-by: Max Staudt <max@xxxxxxxxx>

References:
- [RFC PATCH v3 0/9] can: slcan: extend supported features (step 2)
  - From: Dario Binacchi
- [RFC PATCH v3 3/9] can: slcan: remove legacy infrastructure
  - From: Dario Binacchi