Re: [PATCH 0/3] can: export export slcan_ethtool_ops and remove setter functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27.07.2022 19:49:36, Vincent Mailhol wrote:
> The c_can, flexcan and slcan use a setter function to populate
> net_device::ethtool_ops. Using a setter here add one additional
> function call and add some small bloat in the object file. Exporting
> the structure allow to remove this setter.
> 
> The mcp251xfd uses a similar pattern except that it does some
> additional initialization. As such, this driver is left untouched.
> 
> 
> * Statistics *
> 
> For the slcan driver, this patch reduces the object file by 14 bytes
> (details in the first patch). Although we did not conduct a benchmark
> for the other drivers but we expect the exact same figures.

Applied to can-next/master.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux