On Mon. 25 Jul. 2022 at 23:09, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote: > On 25.07.2022 22:31:54, Vincent Mailhol wrote: > > For all CAN drivers, implement the get_drvinfo() function. > > > > After this patch, it is now possible to retrieve basic information by > > doing: > > > > | $ ethtool -i canX > > This is the output of unpatched mcp251xfd driver. > > | $ ethtool -i mcp251xfd0 > | driver: mcp251xfd > | version: 5.18.10-v8+ > | firmware-version: > | expansion-rom-version: > | bus-info: spi0.0 > | supports-statistics: no > | supports-test: no > | supports-eeprom-access: no > | supports-register-dump: no > | supports-priv-flags: no > > (v5.19/patched is currently compiling} > > IMHO there's no need to implement a default .get_drvinfo callback. BTW: > I removed one from the c_can driver some time ago: > > https://lore.kernel.org/all/20220124215642.3474154-10-mkl@xxxxxxxxxxxxxx/ Oh! struct ethtool_ops does not document that .get_drvinfo has a default implementation. I will remove it. With this removed, patch 1 to 9 are not related anymore so I will split the series in two. Yours sincerely, Vincent Mailhol
