On Thu, Jul 21, 2022 at 05:52:28PM +0200, Marc Kleine-Budde wrote:
> Fix the uninitialized use of errc by moving the ioread32() up, before
> accessing it.
>
> Fixes: 3a5c7e4611dd ("can: pch_can: do not report txerr and rxerr during bus-off")
> Reported-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> Cc: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
Thanks a lot for the quick fix!
> ---
> drivers/net/can/pch_can.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
> index 50f6719b3aa4..32804fed116c 100644
> --- a/drivers/net/can/pch_can.c
> +++ b/drivers/net/can/pch_can.c
> @@ -489,6 +489,7 @@ static void pch_can_error(struct net_device *ndev, u32 status)
> if (!skb)
> return;
>
> + errc = ioread32(&priv->regs->errc);
> if (status & PCH_BUS_OFF) {
> pch_can_set_tx_all(priv, 0);
> pch_can_set_rx_all(priv, 0);
> @@ -502,7 +503,6 @@ static void pch_can_error(struct net_device *ndev, u32 status)
> cf->data[7] = (errc & PCH_REC) >> 8;
> }
>
> - errc = ioread32(&priv->regs->errc);
> /* Warning interrupt. */
> if (status & PCH_EWARN) {
> state = CAN_STATE_ERROR_WARNING;
> --
> 2.35.1
>
>
