On Sat, 16 Jul 2022 19:02:01 +0200 Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx> wrote: > -#include <linux/init.h> > #include <linux/module.h> > - > -#include <linux/bitops.h> > -#include <linux/ctype.h> > -#include <linux/errno.h> > -#include <linux/kernel.h> > -#include <linux/list.h> > -#include <linux/lockdep.h> > -#include <linux/netdevice.h> > -#include <linux/skbuff.h> > -#include <linux/spinlock.h> > -#include <linux/string.h> > #include <linux/tty.h> > -#include <linux/tty_ldisc.h> > -#include <linux/workqueue.h> > - > -#include <uapi/linux/tty.h> > - > -#include <linux/can.h> > #include <linux/can/dev.h> > -#include <linux/can/error.h> > #include <linux/can/rx-offload.h> AFAIK, the coding style is to not rely on headers including other headers. Instead, the appropriate header for every symbol used should be included. This is also valid for the similar patch you submitted for slcan. Unless something has changed, this is a NAK from me, sorry. Max
