Re: [PATCH 4.14 1/4] can: kvaser_usb: Add struct kvaser_usb_dev_cfg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 08, 2022 at 08:46:50PM +0200, Jimmy Assarsson wrote:
> Add struct kvaser_usb_dev_cfg to ease backporting of upstream commits:
> 49f274c72357 (can: kvaser_usb: replace run-time checks with struct kvaser_usb_driver_info)
> e6c80e601053 (can: kvaser_usb: kvaser_usb_leaf: fix CAN clock frequency regression)
> b3b6df2c56d8 (can: kvaser_usb: kvaser_usb_leaf: fix bittiming limits)

What upstream commit is this from?

> 
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Jimmy Assarsson <extja@xxxxxxxxxx>
> ---
>  drivers/net/can/usb/kvaser_usb.c | 76 ++++++++++++++++++++++----------
>  1 file changed, 52 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/net/can/usb/kvaser_usb.c b/drivers/net/can/usb/kvaser_usb.c
> index 9742e32d5cd5..6759868924b2 100644
> --- a/drivers/net/can/usb/kvaser_usb.c
> +++ b/drivers/net/can/usb/kvaser_usb.c
> @@ -31,10 +31,6 @@
>  #define USB_SEND_TIMEOUT		1000 /* msecs */
>  #define USB_RECV_TIMEOUT		1000 /* msecs */
>  #define RX_BUFFER_SIZE			3072
> -#define KVASER_USB_CAN_CLOCK_8MHZ	8000000
> -#define KVASER_USB_CAN_CLOCK_16MHZ	16000000
> -#define KVASER_USB_CAN_CLOCK_24MHZ	24000000
> -#define KVASER_USB_CAN_CLOCK_32MHZ	32000000

You also deleted these, you didn't really describe any of this in the
changelog text at all :(

Why not just backport the needed commit instead of this unknown one?

thanks,

greg k-h



[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux