Re: [PATCH v3 05/13] can: netlink: dump bitrate 0 if can_priv::bittiming.bitrate is -1U

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13.06.2022 22:44:12, Dario Binacchi wrote:
> On Mon, Jun 13, 2022 at 9:11 AM Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> > This would make the code a lot cleaner. Can you think of a nice macro
> > name for the -1?
> >
> > 0 could be CAN_BITRATE_UNCONFIGURED or _UNSET. For -1 I cannot find a
> > catchy name, something like CAN_BITRATE_CONFIGURED_UNKOWN or
> > SET_UNKNOWN.
> >
> 
> Personally I would use CAN_BITRATE_UNSET (0) and CAN_BITRATE_UNKNOWN (-1).
> Let me know what your ultimate preference is.

Looks good.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux