On 11.06.2022 15:16:49, Max Staudt wrote: > On Sat, 4 Jun 2022 00:47:10 +0900 > Vincent Mailhol <vincent.mailhol@xxxxxxxxx> wrote: > > > > > +#define ELM327_CAN_CONFIG_SEND_SFF 0x8000 > > > > +#define ELM327_CAN_CONFIG_VARIABLE_DLC 0x4000 > > > > +#define ELM327_CAN_CONFIG_RECV_BOTH_SFF_EFF 0x2000 > > > > +#define ELM327_CAN_CONFIG_BAUDRATE_MULT_8_7 0x1000 > > > > This ELM327_CAN_CONFIG_BAUDRATE_MULT_8_7 macro is not used. > > True. It does document a flag in the ELM327 configuration registers > though, and it was originally meant for adding 7/8 bitrates (e.g. 87500 > as a companion to 100000). I never got around to implementing those > bitrates, though. > > I find opportunistic documentation helpful for future reference and > to give casual readers hints - can I leave it in there anyway, or is it > deemed an eyesore? IMHO leave it in the driver. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
