On Wed. 8 Jun 2022 à 07:06, Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > On Tue, 7 Jun 2022 18:22:16 +0200 Max Staudt wrote: > > > Honestly, I am totally happy to have the "default y" tag, the "if > > > unsure, say Y" comment and the "select CAN_RX_OFFLOAD" all together. > > > > > > Unless I am violating some kind of best practices, I prefer to keep it > > > as-is. Hope this makes sense. > > AFAIU Linus likes for everything that results in code being added to > the kernel to default to n. A "make defconfig" would not select CONFIG_CAN (on which CAN_RX_OFFLOAD indirectly depends) and so by default this code is not added to the kernel. > If the drivers hard-select that Kconfig > why bother user with the question at all? My understanding is that > Linus also likes to keep Kconfig as simple as possible. I do not think that this is so convoluted. What would bother me is that RX offload is not a new feature. Before this series, RX offload is built-in the can-dev.o by default. If this new CAN_RX_OFFLOAD does not default to yes, then the default features built-in can-dev.o would change before and after this series. But you being one of the maintainers, if you insist I will go in your direction. So will removing the "default yes" and the comment "If unsure, say yes" from the CAN_RX_OFFLOAD satisfy you? > > I wholeheartedly agree with Vincent's decision. > > > > One example case would be users of my can327 driver, as long as it is > > not upstream yet. They need to have RX_OFFLOAD built into their > > distribution's can_dev.ko, otherwise they will have no choice but to > > build their own kernel. > > Upstream mentioning out-of-tree modules may have the opposite effect > to what you intend :( Forgive my ignorance, what's the reason to keep > the driver out of tree? I can answer for Max. The can327 patch is under review with the clear intent to have it upstream. c.f.: https://lore.kernel.org/linux-can/20220602213544.68273-1-max@xxxxxxxxx/ But until the patch gets accepted, it is defacto an out of tree module. Yours sincerely, Vincent Mailhol
