Re: [PATCH] can: ctucanfd: platform: add missing dependency to HAS_IOMEM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Marc,

thanks much for correction.

On Monday 23 of May 2022 14:37:20 Marc Kleine-Budde wrote:
> The kernel test robot noticed that the ctucanfd platform driver fails
> during modpost on platforms that don't support IOMEM.
>
> | ERROR: modpost: "devm_ioremap_resource"
> | [drivers/net/can/ctucanfd/ctucanfd_platform.ko] undefined!
>
> This patch adds the missing HAS_IOMEM dependency.
>
> Fixes: e8f0c23a2415 ("can: ctucanfd: CTU CAN FD open-source IP core -
> platform/SoC support.") Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Cc: Pavel Pisa <pisa@xxxxxxxxxxxxxxxx> (maintainer:CTU CAN FD DRIVER)
> Cc: Ondrej Ille <ondrej.ille@xxxxxxxxx> (maintainer:CTU CAN FD DRIVER)
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Acked-by: Pavel Pisa <pisa@xxxxxxxxxxxxxxxx>
> ---
>  drivers/net/can/ctucanfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/ctucanfd/Kconfig
> b/drivers/net/can/ctucanfd/Kconfig index 3c383612eb17..6e2073351a8f 100644
> --- a/drivers/net/can/ctucanfd/Kconfig
> +++ b/drivers/net/can/ctucanfd/Kconfig
> @@ -23,7 +23,7 @@ config CAN_CTUCANFD_PCI
>
>  config CAN_CTUCANFD_PLATFORM
>  	tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver"
> -	depends on OF || COMPILE_TEST
> +	depends on HAS_IOMEM && (OF || COMPILE_TEST)
>  	select CAN_CTUCANFD
>  	help
>  	  The core has been tested together with OpenCores SJA1000




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux