Re: [PATCH can-next] can: can-dev: remove obsolete CAN LED support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marc,

found a typo while reading your answer ...

On 18.05.22 22:21, Marc Kleine-Budde wrote:
On 18.05.2022 17:45:27, Oliver Hartkopp wrote:
Since commit 30f3b42147ba6f ("can: mark led trigger as broken") the
CAN specific LED support was disabled and marked as BROKEN. As the common
LED support with CONFIG_LEDS_TRIGGER_NETDEV should to this work now the
                                                      ^^

to -> do

m(


Btw. did you see this patch for can-next?

https://lore.kernel.org/linux-can/20220517145653.2556-1-socketcan@xxxxxxxxxxxx/T/#u

That was very short after the patch from Jakub so you probably missed it.

Thanks & BR,
Oliver

code can be removed as preparation for a CAN netdevice Kconfig rework.

Suggested-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
Signed-off-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
---
  drivers/net/can/Kconfig                  |  17 ---
  drivers/net/can/at91_can.c               |  10 --
  drivers/net/can/c_can/c_can_main.c       |  12 +-
  drivers/net/can/ctucanfd/ctucanfd_base.c |  10 --
  drivers/net/can/dev/Makefile             |   2 -
  drivers/net/can/dev/dev.c                |   5 -
  drivers/net/can/dev/rx-offload.c         |   2 -
  drivers/net/can/flexcan/flexcan-core.c   |   7 --
  drivers/net/can/ifi_canfd/ifi_canfd.c    |   9 --
  drivers/net/can/led.c                    | 140 -----------------------
  drivers/net/can/m_can/m_can.c            |  11 --
  drivers/net/can/m_can/m_can.h            |   1 -
  drivers/net/can/rcar/rcar_can.c          |   8 --
  drivers/net/can/rcar/rcar_canfd.c        |   7 --
  drivers/net/can/sja1000/sja1000.c        |  11 --
  drivers/net/can/spi/hi311x.c             |   8 --
  drivers/net/can/spi/mcp251x.c            |  10 --
  drivers/net/can/sun4i_can.c              |   7 --
  drivers/net/can/ti_hecc.c                |   8 --
  drivers/net/can/usb/mcba_usb.c           |   8 --
  drivers/net/can/usb/usb_8dev.c           |  11 --
  drivers/net/can/xilinx_can.c             |  10 +-
  include/linux/can/dev.h                  |  10 --
  include/linux/can/led.h                  |  51 ---------
  24 files changed, 2 insertions(+), 373 deletions(-)
  delete mode 100644 drivers/net/can/led.c
  delete mode 100644 include/linux/can/led.h

Applied to linux-can-next/testing.

regards,
Marc




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux