On 13.05.2022 10:21:45, Jakub Kicinski wrote: > On Fri, 13 May 2022 15:08:18 +0200 Marc Kleine-Budde wrote: > > From: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> > > > > This reverts commit 0e8ffdf3b86dfd44b651f91b12fcae76c25c453b. > > > > Commit 0e8ffdf3b86d ("can: m_can: pci: use custom bit timings for > > Elkhart Lake") broke the test case using bitrate switching. > > > > | ip link set can0 up type can bitrate 500000 dbitrate 4000000 fd on > > | ip link set can1 up type can bitrate 500000 dbitrate 4000000 fd on > > | candump can0 & > > | cangen can1 -I 0x800 -L 64 -e -fb \ > > | -D 11223344deadbeef55667788feedf00daabbccdd44332211 -n 1 -v -v > > > > Above commit does everything correctly according to the datasheet. > > However datasheet wasn't correct. > > > > I got confirmation from hardware engineers that the actual CAN > > hardware on Intel Elkhart Lake is based on M_CAN version v3.2.0. > > Datasheet was mirroring values from an another specification which was > > based on earlier M_CAN version leading to wrong bit timings. > > > > Therefore revert the commit and switch back to common bit timings. > > > > Fixes: 0e8ffdf3b86d ("can: m_can: pci: use custom bit timings for Elkhart Lake") > > Link: https://lore.kernel.org/all/20220512124144.536850-1-jarkko.nikula@xxxxxxxxxxxxxxx > > Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> > > Reported-by: Chee Hou Ong <chee.houx.ong@xxxxxxxxx> > > Reported-by: Aman Kumar <aman.kumar@xxxxxxxxx> > > Reported-by: Pallavi Kumari <kumari.pallavi@xxxxxxxxx> > > Cc: <stable@xxxxxxxxxxxxxxx> # v5.16+ > > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > > nit: the hash in the fixes tag should be: Doh! > Fixes: ea4c1787685d ("can: m_can: pci: use custom bit timings for Elkhart Lake") > > Do you want to respin or is the can tree non-rebasable? No - it's non-rebasable as soon as merged to net(-next) :) Here's a new pull request with a adjusted Fixes tag. | https://lore.kernel.org/all/20220514185742.407230-1-mkl@xxxxxxxxxxxxxx regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature