Re: [PATCH 1/2] Revert "can: m_can: pci: use custom bit timings for Elkhart Lake"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12.05.2022 15:41:43, Jarkko Nikula wrote:
> This reverts commit 0e8ffdf3b86dfd44b651f91b12fcae76c25c453b.
> 
> Commit 0e8ffdf3b86d ("can: m_can: pci: use custom bit timings for
> Elkhart Lake") broke the test case using bitrate switching.
> 
> 	ip link set can0 up type can bitrate 500000 dbitrate 4000000 fd on
> 	ip link set can1 up type can bitrate 500000 dbitrate 4000000 fd on
> 	candump can0 &
> 	cangen can1 -I 0x800 -L 64 -e -fb -D 11223344deadbeef55667788feedf00daabbccdd44332211 -n 1 -v -v
> 
> Above commit does everything correctly according to the datasheet.
> However datasheet wasn't correct.
> 
> I got confirmation from hardware engineers that the actual CAN hardware
> on Intel Elkhart Lake is based on M_CAN version v3.2.0. Datasheet was
> mirroring values from an another specification which was based on earlier
> M_CAN version leading to wrong bit timings.
> 
> Therefore revert the commit and switch back to common bit timings.
> 
> Fixes: 0e8ffdf3b86d ("can: m_can: pci: use custom bit timings for Elkhart Lake")
> Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> Reported-by: Chee Hou Ong <chee.houx.ong@xxxxxxxxx>
> Reported-by: Aman Kumar <aman.kumar@xxxxxxxxx>
> Reported-by: Pallavi Kumari <kumari.pallavi@xxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v5.16+

Added to can/testing.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux