Hi Devid, On Mon, May 09, 2022 at 07:07:44PM +0200, Devid Antonio Filoni wrote: > Hello, > > If candump -x is used to dump CAN bus traffic on an interface while a J1939 > socket is sending multi-packet messages, then the DAT and CTL frames > show up as RX instead of TX. > > This patch series sets to generated struct sk_buff the owning struct sock > pointer so that the MSG_DONTROUTE flag can be set by recv functions. > > I'm not sure that j1939_session_skb_get is needed, I think that session->sk > could be directly passed as can_skb_set_owner parameter. This patch > is based on j1939_simple_txnext function which uses j1939_session_skb_get. > I can provide an additional patch to remove the calls to > j1939_session_skb_get function if you think they are not needed. Thank you for your patches. By testing it I noticed that there is a memory leak in current kernel and it seems to be even worse after this patches. Found by this test: https://github.com/linux-can/can-tests/blob/master/j1939/run_all.sh#L13 Can you please investigate it (or wait until I get time to do it). Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
