Hi Max, I love your patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on linus/master v5.18-rc5 next-20220502] [cannot apply to mkl-can-next/testing linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Max-Staudt/can-tty-elmcan-CAN-ldisc-driver-for-ELM327-based-OBD-II-adapters/20220502-232340 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220503/202205030715.YJrfVKUa-lkp@xxxxxxxxx/config) compiler: arceb-elf-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/abb85fc1dc50ffca72049df7c5714a83d081d6f6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Max-Staudt/can-tty-elmcan-CAN-ldisc-driver-for-ELM327-based-OBD-II-adapters/20220502-232340 git checkout abb85fc1dc50ffca72049df7c5714a83d081d6f6 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from arch/arc/include/asm/bug.h:30, from include/linux/bug.h:5, from include/linux/cpumask.h:14, from include/linux/mm_types_task.h:14, from include/linux/mm_types.h:5, from include/linux/buildid.h:5, from include/linux/module.h:14, from drivers/net/can/elmcan.c:16: drivers/net/can/elmcan.c: In function 'elm327_send': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:130:9: note: in expansion of macro 'lockdep_assert_held' 130 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ drivers/net/can/elmcan.c: In function 'elm327_kick_into_cmd_mode': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:160:9: note: in expansion of macro 'lockdep_assert_held' 160 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ drivers/net/can/elmcan.c: In function 'elm327_send_frame': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:173:9: note: in expansion of macro 'lockdep_assert_held' 173 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ drivers/net/can/elmcan.c: In function 'elm327_init': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:235:9: note: in expansion of macro 'lockdep_assert_held' 235 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ drivers/net/can/elmcan.c: In function 'elm327_feed_frame_to_netdev': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:265:9: note: in expansion of macro 'lockdep_assert_held' 265 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ drivers/net/can/elmcan.c: In function 'elm327_uart_side_failure': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:286:9: note: in expansion of macro 'lockdep_assert_held' 286 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ drivers/net/can/elmcan.c: In function 'elm327_parse_error': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:327:9: note: in expansion of macro 'lockdep_assert_held' 327 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ drivers/net/can/elmcan.c: In function 'elm327_parse_frame': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:394:9: note: in expansion of macro 'lockdep_assert_held' 394 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ drivers/net/can/elmcan.c: In function 'elm327_parse_line': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:516:9: note: in expansion of macro 'lockdep_assert_held' 516 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ drivers/net/can/elmcan.c: In function 'elm327_handle_prompt': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:550:9: note: in expansion of macro 'lockdep_assert_held' 550 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ drivers/net/can/elmcan.c: In function 'elm327_drop_bytes': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:655:9: note: in expansion of macro 'lockdep_assert_held' 655 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ drivers/net/can/elmcan.c: In function 'elm327_parse_rxbuf': >> include/linux/lockdep.h:286:61: error: invalid type argument of '->' (have 'spinlock_t' {aka 'struct spinlock'}) 286 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:122:32: note: in definition of macro 'WARN_ON' 122 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:316:9: note: in expansion of macro 'lockdep_assert' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:316:24: note: in expansion of macro 'lockdep_is_held' 316 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ drivers/net/can/elmcan.c:666:9: note: in expansion of macro 'lockdep_assert_held' 666 | lockdep_assert_held(elm->lock); | ^~~~~~~~~~~~~~~~~~~ vim +286 include/linux/lockdep.h f607c668577481 Peter Zijlstra 2009-07-20 285 f8319483f57f1c Peter Zijlstra 2016-11-30 @286 #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) f8319483f57f1c Peter Zijlstra 2016-11-30 287 #define lockdep_is_held_type(lock, r) lock_is_held_type(&(lock)->dep_map, (r)) f607c668577481 Peter Zijlstra 2009-07-20 288 -- 0-DAY CI Kernel Test Service https://01.org/lkp
