Hello Pavel, Martin, Ondrej,
On 19.04.22 17:35, Marc Kleine-Budde wrote:
On 06.04.2022 10:20:42, Pavel Pisa wrote:
I have missed timing for 5.18 but v5.18-rc1 is out so I would be
happy if we do not miss 5.19 merge window at least with minimal version.
I've taken the patch (almost) as is, I marked both can_bittiming_const
static, as sparse complained about that and I changed the order of two
variable declarations to look nicer :)
Looking forward for more patches!
The patches now landed in net-next \o/
But while checking the automatic review results from Patchwork here ...
https://patchwork.kernel.org/project/netdevbpf/list/?series=&submitter=7454&state=*&q=CTU+CAN+FD&archive=&delegate=
... it looks like that at least the two red 'failed' markers should be
addressed in follow up patches.
The 'inline' warnings are easy to fix:
https://patchwork.hopto.org/static/nipa/633430/12818712/source_inline/stderr
But the module_param()'s in
https://patchwork.hopto.org/static/nipa/633430/12818710/module_param/stderr
should probably be revisited, whether the parameters (PCI/MSI and
'second IP core') could be handled by some automatic detection.
Or did I miss something that makes these module parameters really necessary?
Best regards,
Oliver
