Hi Marc,
On 28.03.22 14:22, Marc Kleine-Budde wrote:
On 28.03.2022 13:36:11, Oliver Hartkopp wrote:
In commit 42bf50a1795a ("can: isotp: support MSG_TRUNC flag when reading
from socket") a new check for recvmsg flags has been introduced that
only checked for the flags that are handled in isotp_recvmsg() itself.
This accidentally removed the MSG_PEEK feature flag which is processed
later in the call chain in __skb_try_recv_from_queue().
Add MSG_PEEK to the set of valid flags to restore the feature.
Fixes: 42bf50a1795a ("can: isotp: support MSG_TRUNC flag when reading from socket")
Link: https://github.com/linux-can/can-utils/issues/347#issuecomment-1079554254
From: Derek Will <derekrobertwill@xxxxxxxxx>
If this patch is from Derek Will, we need Derek's Signed-off-by [1] and
change to author information accordingly.
[1] https://elixir.bootlin.com/linux/v5.12/source/Documentation/process/submitting-patches.rst#L356
Tested-by: Derek Will <derekrobertwill@xxxxxxxxx>
Signed-off-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
If Derek replies to this mail with his S-o-b line, I'll fix the author
while applying the patch.
Although I would have liked Derek to show up as author of the patch
(because of he found the issue) he has not been reacting for some time now.
Therefore I would suggest to take the authorship (I wrote the commit
message anyway) and tag Derek with
Reported/Suggested?/Tested-by if you do not want to wait to push the
other pending patches to Jakub.
Best regards,
Oliver
