Hi Hangyu,
On Fri, Mar 11, 2022 at 5:02 PM Hangyu Hua <hbh25y@xxxxxxxxx> wrote:
>
> There is no need to call dev_kfree_skb when usb_submit_urb fails beacause
> can_put_echo_skb deletes original skb and can_free_echo_skb deletes the cloned
> skb.
So, it's more like, "we don't need to call dev_kfree_skb() after
can_put_echo_skb()
because can_put_echo_skb() consumes the given skb.". It seems it doesn't depend
on the condition of usb_submit_urb(). Plus, we don't see the "cloned
skb" at the
call site.
Would you mind adding a comment on can_put_echo_skb(), in a separate patch,
saying the fact that it consumes the skb?
ems_usb.c, gs_usb.c and possibly some others seem to call
dev_kfree_skb() as well.
Are they affected?
Best,
--
yashi
